Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-919: Remove Stale Feature Flag - fflag_fix_back_LSDV_4748_annotate_task_number_14032023_short #6700

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Nov 21, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Removing a FF that was stale for a few months.

WHEN REVIEW
CHECK THE STALE VALUE FIRST

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 7eaa45c
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/673fbc3b50f0a700087ba78f

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 7eaa45c
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/673fbc3bfa616b0008cc8eb3

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (7479e3e) to head (7eaa45c).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6700   +/-   ##
========================================
  Coverage    76.77%   76.77%           
========================================
  Files          170      170           
  Lines        13883    13883           
========================================
  Hits         10659    10659           
  Misses        3224     3224           
Flag Coverage Δ
pytests 76.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@luarmr
Copy link
Contributor Author

luarmr commented Nov 22, 2024

/git merge

Workflow run
Successfully merged: Already up to date.

@luarmr luarmr merged commit bdc505c into develop Nov 22, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants