Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HCA Login #439

Open
Bento007 opened this issue Sep 10, 2019 · 5 comments
Open

Create HCA Login #439

Bento007 opened this issue Sep 10, 2019 · 5 comments
Assignees

Comments

@Bento007
Copy link
Member

Bento007 commented Sep 10, 2019

As a user of the HCA CLI, I would like to login into the CLI in a intuitive way, so I may use service that require authentication.

Defintion of Done

  • Remove hca dss login
  • Remove hca query login
  • Use a single token for all authenticated request in the hca
  • add hca login
  • add hca login --refresh-token to login and generate a refresh token.
  • add hca revoke to revoke the current refresh token.
@Bento007
Copy link
Member Author

Heads up to @kozbo and @kislyuk that these changes will affect your cli commands.

@kozbo
Copy link
Collaborator

kozbo commented Sep 16, 2019

tagging a few others. @hannes-ucsc @jessebrennan @DailyDreaming

@kozbo kozbo added this to the Q4 2019 Milestone 1 milestone Sep 20, 2019
@Bento007
Copy link
Member Author

Using the revoke endpoint in auth0 will revoke all refresh tokens give to that user by auth0 not just the one provide in the request. We should make a complete logout optional.

def logout(revoke=False)
    """ Logout the user, if revoke is true, all refresh tokens issues 
         to that user for the hca will be revoked."""
    pass

We should also make it clear when logging in that a refresh token is not required and should only be used on secure machines.

@Bento007
Copy link
Member Author

depends on #417

@theathorn theathorn modified the milestones: Q4 2019 Milestone 1, Q4 2019 Milestone 2 Oct 23, 2019
@theathorn theathorn modified the milestones: Q4 2019 Milestone 2, Q4 2019 Milestone 3 Nov 20, 2019
@kozbo
Copy link
Collaborator

kozbo commented Nov 27, 2019

Can we return an error message from hca dss login telling the user to use hca login?

@theathorn theathorn removed this from the Q4 2019 Milestone 3 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants