Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harlequin: 1.25.2 (new formula) #198108

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

mfinelli
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I'm submitting this even though it's not ready because it's not clear to me how to proceed. I followed the instructions in https://docs.brew.sh/Python-for-Formula-Authors but when I ran the poet command I received the following error:

/private/var/folders/py/xhr36wn10x90ctsn3hs2dkk80000gn/T/tmp.HMuSjE82Do/venv/lib/python3.12/site-packages/poet/poet.py:95: PackageVersionNotF
oundWarning: Could not find an exact version match for tree-sitter-languages version 1.10.2; using newest instead
  warnings.warn("Could not find an exact version match for "
/private/var/folders/py/xhr36wn10x90ctsn3hs2dkk80000gn/T/tmp.HMuSjE82Do/venv/lib/python3.12/site-packages/poet/poet.py:118: UserWarning: No s
dist found for tree-sitter-languages
  warnings.warn("No sdist found for %s" % name)

The resulting url and sha256 for tree-sitter-languages is therefore empty and in fact you can see there is no source distribution for tree-sitter-languages (https://pypi.org/project/tree-sitter-languages/#files). What is the usual way to handle python packages that have dependencies that don't have a source distribution?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 18, 2024
@ZhongRuoyu
Copy link
Member

ZhongRuoyu commented Nov 18, 2024

The tree-sitter-languages issue is known (grantjenks/py-tree-sitter-languages#63). Before that's fixed, you can do this:

# sdist issue report, https://github.com/grantjenks/py-tree-sitter-languages/issues/63
resource "tree-sitter-languages" do
url "https://github.com/grantjenks/py-tree-sitter-languages/archive/refs/tags/v1.10.2.tar.gz"
sha256 "cdd03196ebaf8f486db004acd07a5b39679562894b47af6b20d28e4aed1a6ab5"
end

@mfinelli mfinelli force-pushed the harlequin branch 10 times, most recently from d168a94 to 2011d1f Compare November 18, 2024 19:02
Formula/h/harlequin.rb Outdated Show resolved Hide resolved
@mfinelli mfinelli force-pushed the harlequin branch 2 times, most recently from b314ab4 to 99fac6e Compare November 20, 2024 17:35
Formula/h/harlequin.rb Outdated Show resolved Hide resolved
@mfinelli mfinelli force-pushed the harlequin branch 7 times, most recently from 2509478 to b311361 Compare November 25, 2024 16:50
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 26, 2024
harlequin: update test

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Nov 26, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 26, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 26, 2024
Merged via the queue into Homebrew:master with commit 4a4d8a0 Nov 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants