Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust cairovm hints implementation #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

rust cairovm hints implementation #23

wants to merge 4 commits into from

Conversation

Okm165
Copy link
Collaborator

@Okm165 Okm165 commented Oct 25, 2024

No description provided.

@Okm165 Okm165 self-assigned this Oct 25, 2024
@Okm165 Okm165 added the enhancement New feature or request label Oct 25, 2024
@Okm165 Okm165 changed the title rust cairovm hints rust cairovm hints implementation Oct 28, 2024
Okm165
Okm165 commented Oct 29, 2024
View reviewed changes
Copy link
Collaborator Author

@Okm165 Okm165 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use multiline string here and in all const string for better readability. (Like we did in eth_essentials)

Agreed this will help wiith readability but idk maybe my editor does wrong things but i could not make it work with multiline strings - it was not matching and errored with hints not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmkra fmkra fmkra left review comments

@marcellobardus marcellobardus marcellobardus approved these changes

Assignees

@Okm165 Okm165

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Okm165 @marcellobardus @fmkra