Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore TAG_CHANGES in BOARD_VISUAL_STATE=2 TRIGGER blocks #16

Merged
merged 1 commit into from
Oct 28, 2024

Commits on Oct 25, 2024

  1. Restore TAG_CHANGES in BOARD_VISUAL_STATE=2 TRIGGER blocks

    There's some logic in the filter to strip out tag changes that share a
    TRIGGER block with a tag change that sets BOARD_VISUAL_STATE to 2. We
    believe that for some time now, BOARD_VISUAL_STATEs 1 or 2 are related to
    shop manipulation code and not part of what we want to capture in combat.
    
    However! In a recent BGS log, there are tag changes that seem to represent
    enchantments (i.e., ATK and HEALTH buffs) being applied to entities in a
    BOARD_VISUAL_STATE=2 block; whereas in older BGS logs, that happens in
    a separate block.
    
    This change removes the logic that was stripping all BOARD_VISUAL_STATE=2
    block tag changes.
    joolean committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    62a9ec3 View commit details
    Browse the repository at this point in the history