Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Added documentation for custom inboxes #1206

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

hendrik-hackerone
Copy link
Contributor

No description provided.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@hendrik-hackerone you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 106
- 0

98% Markdown
2% YAML
<1% Other

Type of change

Feature - These changes are adding a new feature or improvement to existing code.
1 Message
📚 It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some concerns inline for your consideration.

Image of Graham C Graham C


Reviewed with ❤️ by PullRequest

docs/organizations/custom-inbox-edit.md Outdated Show resolved Hide resolved
docs/organizations/custom-inbox-remove.md Outdated Show resolved Hide resolved
docs/organizations/custom-inboxes-allocating.md Outdated Show resolved Hide resolved
docs/organizations/custom-inboxes-new.md Outdated Show resolved Hide resolved
docs/organizations/custom-inboxes-new.md Outdated Show resolved Hide resolved
docs/organizations/custom-inboxes.md Show resolved Hide resolved
docs/organizations/custom-inboxes.md Outdated Show resolved Hide resolved
@jessiwright
Copy link
Contributor

Give me a few minutes to go through this. It was on my list to write this document this week, but I had to get the images approved first.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #1206 up until the latest commit (852a965). No further issues were found.

Reviewed by:

Image of Graham C Graham C

Combining the pages into 1 document so everything is easier to find/navigate/work with
Removing inaccurate image
Fixing Nav
@jessiwright
Copy link
Contributor

I will approve once images are approved. There are some concerns with design vs production that may alter the images

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #1206 up until the latest commit (c242b95). No further issues were found.

Reviewed by:

Image of Graham C Graham C

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #1206 up until the latest commit (f21b753). No further issues were found.

Reviewed by:

Image of Graham C Graham C

@jessiwright jessiwright merged commit f47435f into master Oct 25, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants