Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gradle Configuration #2093

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jimlyas
Copy link

@jimlyas jimlyas commented Nov 13, 2024

This PR include:

  • Migrating Groovy DSL into Kotlin DSL
  • Migrating from dependency management based on extras to version catalog
  • Migrating from KAPT to KSP (Realm still use KAPT because current version required it)
  • Enable parallel and build caching in gradle properties
  • Enable typesafe project accessors
  • Change allUnitTest task's type from GradleBuild into DefaultTask
  • Move share build logic into plugins

Should resolve #2075

my Habitica User-ID: 7b1043d4-0272-410c-9c04-721b667f1566

@phillipthelen
Copy link
Member

This looks great! you mention KSP not working for realm yet: does that mean the PR is not ready for review/testing and merging or does realm use KAPT for now?

@jimlyas
Copy link
Author

jimlyas commented Nov 16, 2024

What I mean is KSP is already implemented for moshi and hilt.

Current realm gradle plugin require the project to use kapt. Might work if we migrate to io.realm.kotlin and refactor the code. But it might be too far-fecthed from what I originally intended.

This PR still use kapt only for realm.

But the PR is ready for testing and review.

I notice the pipeline is failing because there's no signingrelease.properties, in my local build it's running because I rename the template file. Did I miss something?

Thanks in advance.

Jimly Asshiddiqy added 2 commits November 18, 2024 09:36
 - Removing unused properties in libs.versions.toml
 - Enabling typesafe project accessors
 - Change allUnitTest task from GradleBuild to DefaultTask
@jimlyas
Copy link
Author

jimlyas commented Nov 18, 2024

I already fixed the pipeline issue, previously the build script always looking for the signingrelease.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Update project Gradle setup (move to version catalogs, add shared build-logic)
2 participants