Pepsi Max 🥤 #1486
Open
Pepsi Max 🥤 #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
schmidma
force-pushed
the
pepsi-max
branch
5 times, most recently
from
129b02c
to
4c356bb
Compare
knoellle
reviewed
Nov 13, 2024
| let data_home = get_data_home().wrap_err("failed to get data home")?; | ||
| let cargo_home = data_home.join("container-cargo-home/"); | ||
| format!("\ | ||
| mkdir -p {cargo_home} && |
There was a problem hiding this comment.
Add a trailing backslash here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
I'm excited to announce Pepsi Max, the effervescently revamped version of our command line tool that works hand in hand with the mighty "hulk" robotics framework. While the original Pepsi version had all the right ingredients, this rework brings them together with modern flair and clarity—without adding any extra calories, of course!
Here's what's bubbling up in Pepsi Max:
No More Recompiles for Config Changes: I’ve ditched the hard-coded constants in favor of a
hulk.tomlconfiguration file. Now, adjusting settings like the OS_VERSION of NAO is as easy as opening a can, with no need for recompiling or re-releasing a new version of Pepsi. Just pop, fizz, and go!Standardized Directory Locations: All SDKs and necessary artifacts are now following best practices and residing in XDG data directories, leaving behind the outdated hard-coded user home locations. Think of it as tidying up the fridge for maximum refreshment!
Repository Crate Overhaul: Say goodbye to the spaghetti code! The
repositorycrate has undergone a major cleanup, moving to a module structure with well-documented code. This creates a solid, general-purpose library for interacting with the hulk repository—now that's refreshing!Dynamic Repository Root Detection: The search for the repository root is now done dynamically at runtime. I’m looking for a directory with a
hulk.tomlor using theHULK_DEFAULT_ROOTenvironment variable. This means running Pepsi is now as spontaneous as reaching for your favorite soft drink.Pepsi Max is like opening a fizzing can of productivity with the sleekness of modern coding practices. By aligning this tool with current standards, I've made it easier to read, maintain, and enjoy—just like a thirst-quenching beverage should be.
Looking forward to your thoughts and feedback on this fizzy new take. I hope Pepsi Max will truly refresh your development experience and keep your workflow bubbling!
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test
Extensive use of pepsi... Nearly every command was touched :(