Fix bug that game crush loading level3 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grimmys
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Sorry for the delay before my review, I didn't see the notification earlier.
Thanks for your contribution, it's nice changes 👍
Except the few comments I put, I'm wondering if a better name could be found for global_foes service, I feel like this name doesn't say a lot. But it can be changed later on.
| @@ -38,7 +38,8 @@ | |||
| RACES_DATA_PATH = "data/races.xml" | |||
| CLASSES_DATA_PATH = "data/classes.xml" | |||
|
|
|||
| foes_by_mission: dict[str, list[Foe]] = {} | |||
| from src.services.global_foes import foes_by_mission, link_foe_to_mission | |||
| # foes_by_mission: dict[str, list[Foe]] = {} | |||
There was a problem hiding this comment.
Please remove this commented out line of code since it's not necessary anymore
Grimmys
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through a global dict
foes_by_missionsinitialized and altered in new-developed fileglobal_foes.py, conflict caused by redefintion offoes_by_missionsinload_from_tmx_manager.pyandload_from_xml_manager.pyis solved successfully.