Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Golang lint errors. #1279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michelle192837
Copy link
Collaborator

This should fix most of the lint errors in the repo. I'm ignoring a few files that don't get touched often or don't have obvious fixes (mainly around imports).

@google-oss-prow google-oss-prow bot requested a review from chases2 March 14, 2024 22:59
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michelle192837
Copy link
Collaborator Author

/hold

Review is still appreciated, but ignore the "Use SearchConfiguredTargets when searching targets." commit. (Need to clean up my fork's main branch).

This should fix most of the lint errors in the repo. I'm ignoring a few
files that don't get touched often or don't have obvious fixes (mainly
around imports).
@michelle192837
Copy link
Collaborator Author

/hold cancel

Alright, commits fixed!

@michelle192837
Copy link
Collaborator Author

/lint

Copy link
Contributor

@google-oss-prow google-oss-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michelle192837: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant