Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve write failure experience #2703

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

vipnydav
Copy link
Collaborator

@vipnydav vipnydav commented Nov 22, 2024

Description

Write failure improvements (includes fix for local file inode)
Gives error in case of following scenarios:

  1. If an object is modified from different mount while it is being read from another mount.
    1. If two writers concurrently sync to same object from different mounts, one of them succeed and one of them fails with clobbered error.
  2. The file is deleted from same or different mount before syncing it.
  3. The file is renamed from same or different mount before syncing it.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Done
  2. Unit tests - Done
  3. Integration tests - Automated

@vipnydav vipnydav added the execute-integration-tests Run only integration tests label Nov 22, 2024
@vipnydav vipnydav requested a review from a team as a code owner November 22, 2024 11:18
@kislaykishore kislaykishore requested review from a team, gargnitingoogle and kislaykishore and removed request for a team and gargnitingoogle November 22, 2024 11:19
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.09%. Comparing base (cac0ace) to head (c10704d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/fs/inode/file.go 70.83% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2703      +/-   ##
==========================================
- Coverage   77.21%   77.09%   -0.12%     
==========================================
  Files         113      114       +1     
  Lines       15873    15944      +71     
==========================================
+ Hits        12256    12292      +36     
- Misses       3093     3127      +34     
- Partials      524      525       +1     
Flag Coverage Δ
unittests 77.09% <87.71%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant