Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error in uploader go routine #2695

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashmeenkaur
Copy link
Collaborator

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 71.53846% with 37 lines in your changes missing coverage. Please review.

Project coverage is 77.22%. Comparing base (cac0ace) to head (c9bfd1a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/bufferedwrites/upload_handler.go 71.42% 16 Missing and 6 partials ⚠️
internal/storage/mock/mock_writer.go 50.00% 6 Missing ⚠️
internal/storage/mock/testify_mock_bucket.go 0.00% 6 Missing ⚠️
internal/fs/inode/file.go 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2695      +/-   ##
==========================================
+ Coverage   77.21%   77.22%   +0.01%     
==========================================
  Files         113      113              
  Lines       15873    15963      +90     
==========================================
+ Hits        12256    12328      +72     
- Misses       3093     3104      +11     
- Partials      524      531       +7     
Flag Coverage Δ
unittests 77.22% <71.53%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant