Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing-on-gke enhancements] remove mash dependency #2547

Open
wants to merge 2 commits into
base: garnitin/add-gke-load-testing/upload-outputs-to-gsheet
Choose a base branch
from
Open

[testing-on-gke enhancements] remove mash dependency #2547

wants to merge 2 commits into from
+61 −230

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Oct 3, 2024 •
edited
Loading

Description

Replace mash with monitoring-api everywhere

Purposes:

  • Consistent behavior across all machines
  • Monitoring API has faster runtime than mash.
  • Monitoring API is supported on GCE VM too.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle marked this pull request as ready for review October 3, 2024 07:40
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners October 3, 2024 07:40
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a998865 to ed56ec3 Compare October 3, 2024 17:47
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch 2 times, most recently from 3124adf to 3597a49 Compare October 3, 2024 19:23
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from d50d8d8 to e6a68ea Compare October 4, 2024 05:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 3597a49 to 0e196fe Compare October 4, 2024 05:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 0e196fe to ce3610e Compare October 4, 2024 10:05
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from e6a68ea to d074035 Compare October 7, 2024 10:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ce3610e to d89519e Compare October 7, 2024 10:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from d074035 to cc74d73 Compare October 7, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from d89519e to c84442d Compare October 7, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from cc74d73 to 80a4844 Compare October 7, 2024 10:29
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from c84442d to ed644a8 Compare October 7, 2024 10:29
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 80a4844 to a60dfc7 Compare October 9, 2024 05:58
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ed644a8 to 6afa2b2 Compare October 9, 2024 05:58
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a60dfc7 to 5894807 Compare October 9, 2024 05:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 6afa2b2 to ea03f92 Compare October 9, 2024 05:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 5894807 to 6785cc0 Compare October 9, 2024 07:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ea03f92 to b60a1b0 Compare October 9, 2024 07:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 6785cc0 to c46b3d2 Compare October 9, 2024 07:43
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from b60a1b0 to 679eb61 Compare October 9, 2024 07:43
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from c46b3d2 to a6c8c11 Compare October 9, 2024 07:50
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 679eb61 to e563cf6 Compare October 9, 2024 07:50
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from a6c8c11 to 37cf702 Compare October 10, 2024 06:34
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from d8e5088 to 3b84351 Compare November 7, 2024 06:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from ea7fd6a to e82046e Compare November 7, 2024 06:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 3b84351 to 7fa62f4 Compare November 8, 2024 06:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from e82046e to 29ec670 Compare November 8, 2024 06:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 7fa62f4 to 55e3bbe Compare November 9, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 29ec670 to 8073f45 Compare November 9, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 55e3bbe to db16fda Compare November 12, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 8073f45 to 273d9f3 Compare November 12, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from db16fda to 1f69ff6 Compare November 13, 2024 10:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 273d9f3 to 57379c8 Compare November 13, 2024 10:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 1f69ff6 to 0732c1d Compare November 15, 2024 10:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 57379c8 to e14800c Compare November 15, 2024 10:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 0732c1d to 996a12d Compare November 18, 2024 10:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from e14800c to 33c6184 Compare November 18, 2024 10:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 996a12d to 5cf271a Compare November 20, 2024 14:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 33c6184 to f1c3688 Compare November 20, 2024 14:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 5cf271a to 8459068 Compare November 21, 2024 14:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from f1c3688 to 513f82d Compare November 21, 2024 14:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 8459068 to 2bf8f43 Compare November 22, 2024 06:04
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 513f82d to efdc896 Compare November 22, 2024 06:04
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 2bf8f43 to c475333 Compare November 23, 2024 06:07
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from efdc896 to d7194ca Compare November 23, 2024 06:07
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from c475333 to 9fd2f95 Compare November 25, 2024 06:07
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from d7194ca to d6580a1 Compare November 25, 2024 06:07
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from 9fd2f95 to c2ad0c9 Compare November 26, 2024 06:07
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from d6580a1 to 5f494bd Compare November 26, 2024 06:07
@gargnitingoogle
Replace mash with monitoring-api everywhere
7e72529 
Purposes.
* Consistent behavior across all machines
* Monitoring API has faster runtime than mash.
* Monitoring API is supported on GCE VM too.
@gargnitingoogle
fix some var names
84a82e8
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/upload-outputs-to-gsheet branch from c2ad0c9 to 5ecbc4a Compare November 27, 2024 06:07
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/enhancements/remove-mash-dependency branch from 5f494bd to 84a82e8 Compare November 27, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethiay sethiay sethiay left review comments

@kislaykishore kislaykishore kislaykishore approved these changes

@Tulsishah Tulsishah Awaiting requested review from Tulsishah Tulsishah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gargnitingoogle @kislaykishore @sethiay