Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip binary #2546

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Strip binary #2546

wants to merge 1 commit into from

Conversation

kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Oct 2, 2024

Description

Pass the -s and -w ldflags to exclude debugging information. This will also exclude stacktraces, so need to check if it's okay not having them.

Perf impact

Branch File Size Read BW Write BW RandRead BW RandWrite BW
Master 0.25MiB 460.12MiB/s 1.22MiB/s 65.71MiB/s 1.18MiB/s
PR 0.25MiB 450.62MiB/s 1.29MiB/s 64.6MiB/s 1.15MiB/s
Master 48.828MiB 3861.01MiB/s 75.45MiB/s 1188.33MiB/s 76.82MiB/s
PR 48.828MiB 3774.37MiB/s 75.93MiB/s 1248.69MiB/s 77.35MiB/s
Master 976.562MiB 3725.69MiB/s 29.38MiB/s 414.35MiB/s 29.49MiB/s
PR 976.562MiB 3535.02MiB/s 29.33MiB/s 550.4MiB/s 30.78MiB/s

Link to the issue in case of a bug fix.

b/372620195

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant