borrowing fixes from merge branch

GoogleCloudPlatform · Aug 6, 2024 · 478921c · 478921c
1 parent 6c90cc7
commit 478921c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py b/perfmetrics/scripts/testing_on_gke/examples/dlio/dlio_workload.py
@@ -21,7 +21,7 @@ def validateDlioWorkload(workload: dict, name: str):
     return False
 
   dlioWorkload = workload['dlioWorkload']
-  for requiredAttribute, _type in {
+  for requiredAttribute, expectedType in {
       'numFilesTrain': int,
       'recordLength': int,
       'batchSizes': list,
@@ -32,10 +32,11 @@ def validateDlioWorkload(workload: dict, name: str):
           f' {requiredAttribute} in it'
       )
       return False
-    if not type(dlioWorkload[requiredAttribute]) is _type:
+    if not type(dlioWorkload[requiredAttribute]) is expectedType:
       print(
           f'In {name}, dlioWorkload[{requiredAttribute}] is of type'
-          f' {type(dlioWorkload[requiredAttribute])}, not of type {_type} '
+          f' {type(dlioWorkload[requiredAttribute])}, expected:'
+          f' {expectedType} '
       )
       return False
 

diff --git a/perfmetrics/scripts/testing_on_gke/examples/fio/fio_workload.py b/perfmetrics/scripts/testing_on_gke/examples/fio/fio_workload.py
@@ -21,7 +21,7 @@ def validateFioWorkload(workload: dict, name: str):
     return False
 
   fioWorkload = workload['fioWorkload']
-  for requiredAttribute, _type in {
+  for requiredAttribute, expectedType in {
       'fileSize': str,
       'blockSize': str,
       'filesPerThread': int,
@@ -30,10 +30,11 @@ def validateFioWorkload(workload: dict, name: str):
     if requiredAttribute not in fioWorkload:
       print(f'In {name}, fioWorkload does not have {requiredAttribute} in it')
       return False
-    if not type(fioWorkload[requiredAttribute]) is _type:
+    if not type(fioWorkload[requiredAttribute]) is expectedType:
       print(
           f'In {name}, fioWorkload[{requiredAttribute}] is of type'
-          f' {type(fioWorkload[requiredAttribute])}, not of type {_type} '
+          f' {type(fioWorkload[requiredAttribute])}, expected:'
+          f' {expectedType} '
       )
       return False