Unprivileged containers #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 PR staged at http://34.66.157.132 |
|
Ready for your review, thanks! Proposing to merge this taking into account all the apps, for the 2 databases that will be done later in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixing #517 just for the apps, but not for the 2 databases yet.
Update the Kubernetes manifest of any
DeploymentswithsecurityContextfeatures.Like we did with Online Boutique here: GoogleCloudPlatform/microservices-demo#887
Implementation:
securityContext/tmpinstead of/rootfolderOut of scope for now: The 2 databases are still running in privilege mode, there is more work and test to do in a future PR. We need to take inspiration of what is made here: https://github.com/bitnami/charts/blob/master/bitnami/postgresql/templates/primary/statefulset.yaml)
Tests: