Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't ignore /favicon.ico request #829

Closed
wants to merge 2 commits into from
Closed

fix: don't ignore /favicon.ico request #829

wants to merge 2 commits into from

Conversation

Lightning00Blade
Copy link
Collaborator

@Lightning00Blade Lightning00Blade commented Jun 7, 2023 •
edited
Loading

I don't see anything it the spec that says that these events should be ignored.

@thiagowfx
Copy link
Contributor

One of the WPT tests fails

@sadym-chromium
Copy link
Collaborator

One of the WPT tests fails

w3c/webdriver-bidi#204 (comment)

@thiagowfx
Copy link
Contributor

Are you moving forward with this?

@Lightning00Blade
Copy link
Collaborator Author

I would prefere to fix the WPT test to ignore favicon.ico requests. Most likely I will get time next month.

@sadym-chromium
Copy link
Collaborator

I would prefere to fix the WPT test to ignore favicon.ico requests. Most likely I will get time next month.

SGTM

@thiagowfx
Copy link
Contributor

I would prefere to fix the WPT test to ignore favicon.ico requests. Most likely I will get time next month.

Then can we close this PR?

@thiagowfx
Copy link
Contributor

Feel free to reopen it if warranted.

@thiagowfx thiagowfx closed this Jun 28, 2023
@thiagowfx thiagowfx deleted the fix-favicon-requests branch June 28, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagowfx thiagowfx thiagowfx approved these changes

@sadym-chromium sadym-chromium Awaiting requested review from sadym-chromium

Assignees

@Lightning00Blade Lightning00Blade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lightning00Blade @thiagowfx @sadym-chromium