Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with keyhole sectors #45

Closed
jkretz opened this issue Jul 14, 2023 · 6 comments · Fixed by #46
Closed

Problem with keyhole sectors #45

jkretz opened this issue Jul 14, 2023 · 6 comments · Fixed by #46

Comments

@jkretz
Copy link
Contributor

jkretz commented Jul 14, 2023

When analyzing a recent competition day, I realized that pysoar/opensoar has a problem with keyhole sectors. When flying through the 500m cylinder, a valid turnpoint is detected. Flying outside the cylinder but within the 90-degree sector results in an invalid turnpoint.

You may find an example in this competition day:
https://www.soaringspot.com/en_gb/altmarkpokal-2023-stendal/results/standard/task-6-on-2023-07-07/daily

@GliderGeek
Copy link
Owner

I fixed a problem with aat sectors in the latest release v1.1.0, is the problem you describe present in this version?

@jkretz
Copy link
Contributor Author

jkretz commented Jul 14, 2023

It is related to racing tasks. I have been using pysoar 0.63 for Mac

@jkretz
Copy link
Contributor Author

jkretz commented Jul 14, 2023

It is related to the recent AAT fix, but I haven't fully understood the changes yet

@jkretz
Copy link
Contributor Author

jkretz commented Jul 14, 2023

It seems to be related to the (180 - angle_wrt_orientation) part that you recently added. Unfortunately, I don't fully understand why this was needed so I won't try to fix it

Here an image of the turnpoint in question if that helps (See flight of JK in the soaringspot URL of that day):
grafik

@GliderGeek
Copy link
Owner

Thanks for the extra info. This part was difficult to understand, so i probably made a mistake. Luckily i created some geojson export functionality to help debugging last time

@GliderGeek GliderGeek mentioned this issue Jul 17, 2023
4 tasks
@GliderGeek
Copy link
Owner

good catch @jkretz. I'm addressing it here: #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants