Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sca): move SCA models from ggshield to pygitguardian #69

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

xblanchot-gg
Copy link
Contributor

No description provided.

@xblanchot-gg xblanchot-gg added the skip-changelog No changelog check in the CI label Aug 17, 2023
@xblanchot-gg xblanchot-gg self-assigned this Aug 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #69 (9ae9bf4) into master (f413ff1) will decrease coverage by 0.78%.
The diff coverage is 87.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   92.96%   92.19%   -0.78%     
==========================================
  Files           5        6       +1     
  Lines         526      615      +89     
==========================================
+ Hits          489      567      +78     
- Misses         37       48      +11     
Flag Coverage Δ
unittests 92.19% <87.64%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pygitguardian/client.py 79.82% <67.64%> (-2.19%) ⬇️
pygitguardian/sca_models.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks, looks good overall.

pygitguardian/client.py Outdated Show resolved Hide resolved
tests/test_sca_models.py Outdated Show resolved Hide resolved
@agateau-gg agateau-gg merged commit 1cd6812 into master Aug 21, 2023
19 checks passed
@agateau-gg agateau-gg deleted the xblanchot/SCA-917/add_sca_models branch August 21, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog check in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants