-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial 4 - Geophysics (Seismology): Add JN #8
base: main
Are you sure you want to change the base?
Conversation
Hi @yvonnefroehlich |
Yep, I am sorry, I mean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @jhtong33 , for getting started here 👍!
I made a few updates:
- I prefer to use the Scientific colour maps by F. Crameri, i.e., for topography, "oleron".
- I reduced the resolution of the image showing within the Jupyter notebook to keep the file size smaller.
- I figured out that list input is supported for the
center
andendpoint
parameters ofproject
. - Fix typo
grdproject
toproject
. - So minor code style improvements.
- I think we should be consistent and use either single (
'
) or double ("
) quotation marks; I prefer double quotation marks.
Great! Thanks for your updates. |
Hi @yvonnefroehlich |
In this tutorial, we create a more complex figure across multiple cells. In this case, re-running cells to play around with different arguments for the parameters does not work (it only works for the cell that contains the creation of the new Figure instance). To improve this, I was wondering if it can work to create for each cell a new "figure variable", i.e. start with |
So, some more updates
|
Understanding your concerns, this approach achieves the same results we expected. By doing it this way, we can avoid altering the original figure.
I prefer using a black line since color-coding does not better visualize the topography variations. The y-axis already effectively indicates this information. |
Hi @yvonnefroehlich, I think this tutorial can be reviewed. |
Totally fine! Maybe using the same color as the profil line has would nice (in our case red). |
Hm. But for me, this approach does not work in the expected way. Actually, this reminds me a bit of ObsPy where users actively need to copy the Stream object, before applying any processing steps in case they want to keep their raw data in the initial variable unchanged (https://docs.obspy.org/packages/autogen/obspy.core.stream.Stream.copy.html). |
I misunderstood your meaning previously. I also encounter same condition in Jupyter lab. |
As this
No worries! |
This PR adds the Jupyter notebook for Tutorial 4 - Geophysics (Seismology).
Content:
pygmt.xyz2grd
pygmt.Figure.grdcontour
pygmt.project
andpygmt.grdtrack
Feel free to fill the subsections with suggestions for code and docs🙂.
Preview:
Fixes: #6