-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial 2 - scientific Python ecosystem: pandas and GeoPandas: Add JN #4
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notebook looks very clean and easy to follow so far! Just some minor suggestions for now, not sure if you're planning to add more materials to this notebook?
Thanks @weiji14 for already looking at this JN and the positive feedback! I feel the general structure should be finished. What is missing is some documentation and improvements of the formulations, as you already suggested. |
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
Just a simple suggestion, using individual cells can help beginners understand how to set a region. |
This is a good suggestions! Moved these lines to a separate cell. |
I think is ready to merge. My only minor suggestion would be to add a frame to the choropleth map. |
@@ -13,3 +13,4 @@ parts: | |||
- file: markdown | |||
- file: notebooks | |||
- file: markdown-notebooks | |||
- file: tut2_spec_pd_gpd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to add the file names of the JNs or files together within one PR to avoid merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just leave it as is, it'll be a good example to learn how to handle merge conflicts 🙂
# Tutorial 2 - pandas and GeoPandas, Tutorial 4 - Geophysics (Seismology) | ||
- pandas=2.2.2 | ||
- geopandas=1.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, maybe better to update the environment.yml
within one PR for all tutorials to avoid merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since pandas
is a required dependency of pygmt
, this won't need to be added here, unless you specifically require pandas=2.2.2
?
Note that I'll be updating the conda-lock.yml
file to pin all dependencies once all the tutorial notebooks are merged, so that people can reproduce the exact dependency versions in the future (including pandas).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I specifically need this pandas version. Just added the version I am currently having installed in the virtual environment I am using for this pre-workshop.
This PR adds the Jupyter notebook for Tutorial 2 - scientific Python ecosystem:
pandas
andGeoPandas
:Preview: