Fix of Project Bench, Auto Crafting Bench and Plan Recipe

[Elkatra2]

Related issues :

1. Project Bench

• ProjectRed project bench instantly breaking tools GT-New-Horizons-Modpack#14127
• ProjectRed Project Bench consumes Pam's cookware after crafting a single recipe. GT-New-Horizons-Modpack#12634
• Project bench consumes GT tools GT-New-Horizons-Modpack#11423

2. Auto Crafting Bench

• Project Red bench does not check validity of the craft, possible abuse GT-New-Horizons-Modpack#16829
• ProjectRed Expansion Auto Crafting Bench duplicates Fresh Milk GT-New-Horizons-Modpack#14537

3. Plan Recipe

• [ProjectRed Expansion] Can't see accurately what is the item in Recipe Plan while holding LEFT/RIGHT SHIFT on the Project or Auto Crafting Bench GT-New-Horizons-Modpack#14182

Related PR :

• Fix of OreDictionary matching in matches at itemequality MrTJPCore#9

Changes in Project Bench :

1. Crafting logic/rework

1.1 Item with container now will return container during crafting.

• If it's unstack-able item like GT tool or from Pam's HarvestCraft it will return to the same slot
• If it's stack-able like graphite cell for arc furnace it will return to the storage or 2.

1.2 If the storage is full and the item is stack-able, the container from this item will be dropped to ground

1.3 If the crafting recipe is not the same as the plan recipe, required items will no more take resources from storage

1.4 No more milk duping machine, fixed OreDictionary

1.5 Empty buckets can now stacking

1.6 When shift + click items are send to Project Bench storage

1.7 When the inventory is full and you try to shift + click craft it will send the next message chat :

Yes it will send this message twice, due to weird logic behind me

• TODO remove in future because I'm lazy to fix this now...

Changes in Auto Crafting Bench :

1. Crafting logic fixes

1.1 No more milk duping machine, fixed OreDictionary

Changes in Plan Recipe :

1. Animation fix/rework

Before :

Screencast.from.2024-08-29.23-47-52.webm

After :

Screencast.from.2024-08-31.15-20-25.webm

Added :

• When you click shift at any time you can see what is the recipe output, without entering to one of the benches

Removed :

• Glowing animation from benches GUI. Reason : when you do the same thing with AE2 pattern you can see also the output at any time, without glowing (this is what people from ru-general telled me), so I decided to do the similar way.

[Elkatra2]

I will see if I can fix several issues for Auto Crafting Bench and Project Bench and maybe others things from ProjectRed

[Elkatra2]

Closing due to working with prototypes of new primitives (like RailCraft) GT Coke Ovens for Stone/Steam ages

[Dream-Master]

@Elkatra2 is this not fix able or you fix it iside other mods ?

[Elkatra2]

@Elkatra2 is this not fix able or you fix it iside other mods ?

this is about Project Bench ? It's maybe fixable, but I'm bad at Scala/Java, or I can try to do like in forestry wortable, when all the output is sended to inventory of the bench and then to player if the inv is full, also I tring to fix Overflow Valve from GT

[Dream-Master]

better a bad fix that is working as no fix ? Sure if it is fixed elesewhere in another mod its good to.

[Elkatra2]

better a bad fix that is working as no fix ? Sure if it is fixed elesewhere in another mod its good to.

I will try to check again what's happen again

[Elkatra2]

It's time to do some works

[Elkatra2]

I think it's ready, but ... maybe 1.6 and 2 from Project Bench section should be done ...

[brandyyn]

GTNewHorizons/GT-New-Horizons-Modpack#16546

was apparently mentioned here but I can’t find it?

[Elkatra2]

GTNewHorizons/GT-New-Horizons-Modpack#16546

was apparently mentioned here but I can’t find it?

I haved plans to see, but then I made a decision: "maybe someday next time" and removed from pull.

Didn't know that it's not remove from the issue if I removed from PR.

[Elkatra2]

This part can be weird, but it will be removed in future, still bad at scala syntax