Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering to LinearApolloDisplay #469

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shashankbrgowda
Copy link
Contributor

Copy link
Contributor

@garrettjstevens garrettjstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that if a feature type is in the filtered list, but then is removed, the features of that type don't disappear immediately, you have to refresh the page. This is because those features are already in the seenFeatures and don't get removed. I don't think we should remove them from the seenFeatures, though.

Instead of of checking the filter in the afterAttach of layout.ts, I think it should be checked in the featureLayouts and featuresMinMax views. That way the features are still always loaded, just not always displayed, and changes to the filter should show up immediately without a page refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filtering to LinearApolloDisplay
2 participants