Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ESMF_GridComp creation performance #2894

Open
wants to merge 31 commits into
base: release/MAPL-v3
Choose a base branch
from

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

In MAPL3, we will be creating many more ESMF_GridComp objects. In anticipation of this, this benchmark tests the performance of ESMF_GridComp objects.

Related Issue

@darianboggs darianboggs added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Jul 5, 2024
@darianboggs darianboggs self-assigned this Jul 5, 2024
@darianboggs darianboggs requested review from a team as code owners July 5, 2024 19:18
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for memory measurement before further review.

@mathomp4
Copy link
Member

mathomp4 commented Jul 5, 2024

Well GNU is unhappy:

/root/project/MAPL/benchmarks/esmf/gridcomp_creation/GridCompCreationTester.F90:33:23:

   33 |       read(raw, fmt='(I)', iostat=status) npes
      |                       1
Error: Nonnegative width required in format string at (1)
/root/project/MAPL/benchmarks/esmf/gridcomp_creation/GridCompCreationTester.F90:38:23:

   38 |       read(raw, fmt='(I)', iostat=status) ngc
      |                       1
Error: Nonnegative width required in format string at (1)
make[2]: *** [benchmarks/esmf/gridcomp_creation/CMakeFiles/gridcomp_create.x.dir/build.make:75: benchmarks/esmf/gridcomp_creation/CMakeFiles/gridcomp_create.x.dir/GridCompCreationTester.F90.o] Error 1

I think it's as simple as II0 (unless you know the width).

@darianboggs darianboggs marked this pull request as draft July 17, 2024 18:01
@mathomp4
Copy link
Member

Oh yeah. Notice for @darianboggs, @tclune wanted you to try out this benchmark along with the @atrayano memory profiler.

@darianboggs
Copy link
Contributor Author

Oh yeah. Notice for @darianboggs, @tclune wanted you to try out this benchmark along with the @atrayano memory profiler.

OK. Will reach out to Atanas/Tom

@darianboggs darianboggs marked this pull request as ready for review August 20, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants