Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible DT for different grid comps #1369

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

weiyuan-jiang
Copy link
Contributor

flexible DT for different grid comps

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Feb 16, 2022
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner February 16, 2022 17:03
@weiyuan-jiang
Copy link
Contributor Author

@atrayano , In Moist grid comp, the implementation for flexible DT is already in place. The problem is the ring time. If we create the generic alarm in different way, we don't need to change Moist grid comp ( may be other grid comps too). In Config rc file, if we add "MOIST_DT:" and "MOIST_ALARM_RING_AT_0: YES", it should work.

@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the ❄️ Stale This issue has been marked stale label Apr 18, 2022
@stale
Copy link

stale bot commented Apr 25, 2022

Closing due to inactivity

@stale stale bot closed this Apr 25, 2022
@mathomp4
Copy link
Member

I'm going to re-open this until @weiyuan-jiang and @atrayano say whether to close or not.

@mathomp4 mathomp4 reopened this Apr 26, 2022
@stale stale bot removed the ❄️ Stale This issue has been marked stale label Apr 26, 2022
@mathomp4 mathomp4 added ⌛ Long Term Long term issues labels May 16, 2022
@mathomp4
Copy link
Member

mathomp4 commented May 9, 2023

@bena-nasa @weiyuan-jiang This isn't needed anymore, right? I mean, if anything Ben has new code needed by Bill for his "chemistry on different DT"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. ⌛ Long Term Long term issues 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants