Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add dependabot #24

Merged
merged 2 commits into from
Jun 25, 2024
Merged

ci: add dependabot #24

merged 2 commits into from
Jun 25, 2024

Conversation

untereiner
Copy link

No description provided.

@untereiner untereiner linked an issue Jun 24, 2024 that may be closed by this pull request
@untereiner untereiner self-assigned this Jun 24, 2024
Copy link
Collaborator

@cssherman cssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - have you worked with dependabot before? Given the config, what do you expect the alerts look like?

@untereiner
Copy link
Author

It should look like this one: GEOS-DEV/GEOS#3154
I think I can also assign the PR to someone to merge it.

@untereiner
Copy link
Author

I added you to the reviewer list. Let's try it.

@cssherman
Copy link
Collaborator

@untereiner - looking at the failed test, it seems like the network may be causing some issues with pip install (see https://stackoverflow.com/questions/71435874/pip-these-packages-do-mot-match-the-hashes-from-the-requirements-file). Thoughts?

@untereiner
Copy link
Author

It seems very arbitrary.
I know more poetry. I found a tuto to build and publish but didn’t find a good one for linting and testing. Do we agree that testing is the only reason to install locally in the ci the dependencies ?

@untereiner
Copy link
Author

I would avoid the « requirements.txt not in the repo » thing by using tox for testing. Python guys are sometimes quite fool see pypa/pip#11440

@untereiner
Copy link
Author

@cssherman I think the test workflow could be updated but it should be in another PR.
I propose to merge this one and I will open a new one for this subject.

@untereiner untereiner merged commit 2e9cf86 into main Jun 25, 2024
31 checks passed
@untereiner untereiner deleted the update-github-actions branch June 25, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update github-actions
2 participants