Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RESQML support from GEOS #2969

Merged
merged 4 commits into from
Jun 12, 2024
Merged

remove RESQML support from GEOS #2969

merged 4 commits into from
Jun 12, 2024

Conversation

untereiner
Copy link
Contributor

@untereiner untereiner added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review flag: requires updated TPL(s) Needs a specific TPL PR ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline labels Jan 31, 2024
@untereiner untereiner self-assigned this Jan 31, 2024
@untereiner
Copy link
Contributor Author

@TotoGaz I don't know how to deal with the spack recipes. Should I remove them too ? They could be necessary for building geos with spack with the RESQML external component

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.76%. Comparing base (ed3cbce) to head (619144d).
Report is 102 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2969      +/-   ##
===========================================
- Coverage    53.76%   53.76%   -0.01%     
===========================================
  Files         1016     1016              
  Lines        85781    85781              
===========================================
- Hits         46122    46120       -2     
- Misses       39659    39661       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmhan12
Copy link
Contributor

bmhan12 commented Jan 31, 2024

@untereiner I can remove them from spack if they are no longer being used.

@TotoGaz
Copy link
Contributor

TotoGaz commented Jan 31, 2024

That would be nice, thank you @bmhan12
@untereiner does it make sense to keep the spack recipe if we're not using/validating it anymore? Is the git history enough if we want to revive it?

@untereiner
Copy link
Contributor Author

Thank you @bmhan12 ! If think the git history is enough. I am wondering how to play with these recipes with what I call an « external component » eg: added at compile time but in another repository

@TotoGaz
Copy link
Contributor

TotoGaz commented Jan 31, 2024

I am wondering how to play with these recipes with what I call an « external component » eg: added at compile time but in another repository

You mean spack recipes? I've never been using spack so I do not know.

@untereiner
Copy link
Contributor Author

Yes, I ment spack recipes.

@untereiner
Copy link
Contributor Author

@TotoGaz This one should be easy

@untereiner untereiner added flag: TPL(s) build check A PR accompanying a TPL PR to check against GEOS's CI and removed flag: TPL(s) build check A PR accompanying a TPL PR to check against GEOS's CI labels Jun 3, 2024
@CusiniM CusiniM merged commit d2225bd into develop Jun 12, 2024
26 checks passed
@CusiniM CusiniM deleted the fix/deleteFesapi branch June 12, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review flag: requires updated TPL(s) Needs a specific TPL PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants