-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove RESQML support from GEOS #2969
Conversation
@TotoGaz I don't know how to deal with the spack recipes. Should I remove them too ? They could be necessary for building geos with spack with the RESQML external component |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2969 +/- ##
===========================================
- Coverage 53.76% 53.76% -0.01%
===========================================
Files 1016 1016
Lines 85781 85781
===========================================
- Hits 46122 46120 -2
- Misses 39659 39661 +2 ☔ View full report in Codecov by Sentry. |
@untereiner I can remove them from spack if they are no longer being used. |
That would be nice, thank you @bmhan12 |
Thank you @bmhan12 ! If think the git history is enough. I am wondering how to play with these recipes with what I call an « external component » eg: added at compile time but in another repository |
You mean |
Yes, I ment spack recipes. |
@TotoGaz This one should be easy |
Companion PR GEOS-DEV/thirdPartyLibs#258