Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added team members details as JSON file #62

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Added team members details as JSON file #62

merged 4 commits into from
Oct 16, 2023

Conversation

mrshivamshaw
Copy link
Member

@mrshivamshaw mrshivamshaw commented Oct 16, 2023 •
edited
Loading

Related Issue

Proposed Changes

  • Change 1
  • Change2
  • Change 3

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

@netlify
Copy link

netlify bot commented Oct 16, 2023 •
edited
Loading

✅ Deploy Preview for gdscaec ready!

Name Link
🔨 Latest commit 906b35c
🔍 Latest deploy log https://app.netlify.com/sites/gdscaec/deploys/652d56505ccf1e000816b0e3
😎 Deploy Preview https://deploy-preview-62--gdscaec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TheCodeVenturer
TheCodeVenturer requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@TheCodeVenturer TheCodeVenturer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamshaw07
you have changed some styles, which was not addressed by this issue.

Please change that

@TheCodeVenturer TheCodeVenturer linked an issue Oct 16, 2023 that may be closed by this pull request
[Docs] Create a json file with an array of all Team Members #61
Closed
@TheCodeVenturer TheCodeVenturer merged commit 28a1149 into GDGCampusAEC:main Oct 16, 2023
5 checks passed
TheCodeVenturer added a commit that referenced this pull request Oct 16, 2023
@TheCodeVenturer
restored style/style.css deleted by mistake in #62
1c9042f
@TheCodeVenturer TheCodeVenturer added the hacktoberfest-accepted Label for accepted PRs made during hacktoberfest label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCodeVenturer TheCodeVenturer TheCodeVenturer approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Label for accepted PRs made during hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Create a json file with an array of all Team Members
2 participants
@mrshivamshaw @TheCodeVenturer