Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bobbing navBar issue #59

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Fixed bobbing navBar issue #59

merged 2 commits into from
Oct 15, 2023

Conversation

mrshivamshaw
Copy link
Member

@mrshivamshaw mrshivamshaw commented Oct 15, 2023 •
edited
Loading

Related Issue

Proposed Changes

  • Change 1 : fixed height to 28px
  • Change 2 : fixed padding to 20px

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

@netlify
Copy link

netlify bot commented Oct 15, 2023 •
edited
Loading

✅ Deploy Preview for gdscaec ready!

Name Link
🔨 Latest commit fbb03cd
🔍 Latest deploy log https://app.netlify.com/sites/gdscaec/deploys/652c248a8a4f360008494df6
😎 Deploy Preview https://deploy-preview-59--gdscaec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Oct 15, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings from GDSC AEC! Thanks for making the PR, our team will review it soon. Stay tuned 😊

TheCodeVenturer
TheCodeVenturer requested changes Oct 15, 2023
View reviewed changes
Copy link
Member

@TheCodeVenturer TheCodeVenturer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shivamshaw07 ,
image
top of the image is hidden with the navbar

TheCodeVenturer
TheCodeVenturer approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@TheCodeVenturer TheCodeVenturer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @shivamshaw07

@TheCodeVenturer TheCodeVenturer merged commit 28a5324 into GDGCampusAEC:main Oct 15, 2023
5 checks passed
@TheCodeVenturer TheCodeVenturer added the hacktoberfest-accepted Label for accepted PRs made during hacktoberfest label Oct 15, 2023
@TheCodeVenturer TheCodeVenturer linked an issue Oct 15, 2023 that may be closed by this pull request
[Bug] Fix bobbing navbar issue on scroll-down #50
Closed
@TheCodeVenturer TheCodeVenturer mentioned this pull request Oct 15, 2023
Closed
@mrshivamshaw
Copy link
Member Author

@TheCodeVenturer Thank you☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@TheCodeVenturer TheCodeVenturer TheCodeVenturer approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Label for accepted PRs made during hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix bobbing navbar issue on scroll-down
2 participants
@mrshivamshaw @TheCodeVenturer