Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #54 #58

Merged
merged 11 commits into from
Oct 16, 2023
Merged

Conversation

Taofeeqah
Copy link
Contributor

Related Issue

  • Issue number goes here: 54

Proposed Changes

  • increased the sizes of the social media icons on the team cards
  • made the team cards responsive according to the instruction
  • removed and added necessary styles to achieve my goal

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

screen-ll-720aec
screen-l-720aec
screen-g-720-aec
screen-g-1023aec

@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for gdscaec ready!

Name Link
🔨 Latest commit aae1531
🔍 Latest deploy log https://app.netlify.com/sites/gdscaec/deploys/652d4ca89b728f0008807707
😎 Deploy Preview https://deploy-preview-58--gdscaec.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings from GDSC AEC! Thanks for making the PR, our team will review it soon. Stay tuned 😊

Copy link
Member

@TheCodeVenturer TheCodeVenturer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Taofeeqah,
Some Designs need to be updated,

  1. In the first row there will be only one card and in second row there will be two and for rest the design is good
    i,e. First row only Niraj's Card, Second Row only Jayanata's and Bishal's Card
    and rest as implemented

  2. In some breakpoints the side (stair/zig-zag) design collides with the team member card

  3. Add your name in the CONTRIBUTORS file

@TheCodeVenturer
Copy link
Member

For more details you can contact use over Discord Derver

@Taofeeqah
Copy link
Contributor Author

Ok. Noted!

@Taofeeqah
Copy link
Contributor Author

Effected the requested changes

Copy link
Member

@TheCodeVenturer TheCodeVenturer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write Your name in CONTRIBUTORS @Taofeeqah
Rest is good

@Taofeeqah
Copy link
Contributor Author

Thank you. I've added my name to the contributiors file.

@TheCodeVenturer TheCodeVenturer linked an issue Oct 16, 2023 that may be closed by this pull request
@TheCodeVenturer TheCodeVenturer added the hacktoberfest-accepted Label for accepted PRs made during hacktoberfest label Oct 16, 2023
@TheCodeVenturer TheCodeVenturer merged commit 1d28aaf into GDGCampusAEC:main Oct 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Label for accepted PRs made during hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Core team cards are too large
2 participants