-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue #54 #58
fixed issue #54 #58
Conversation
…siveness of the team cards
…siveness of the team cards
…siveness of the team cards
…siveness of the team cards
✅ Deploy Preview for gdscaec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings from GDSC AEC! Thanks for making the PR, our team will review it soon. Stay tuned 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Taofeeqah,
Some Designs need to be updated,
-
In the first row there will be only one card and in second row there will be two and for rest the design is good
i,e. First row only Niraj's Card, Second Row only Jayanata's and Bishal's Card
and rest as implemented -
In some breakpoints the side (stair/zig-zag) design collides with the team member card
-
Add your name in the CONTRIBUTORS file
For more details you can contact use over Discord Derver |
Ok. Noted! |
Effected the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write Your name in CONTRIBUTORS @Taofeeqah
Rest is good
Thank you. I've added my name to the contributiors file. |
Added my name to the contributors list
Related Issue
Proposed Changes
Checklist
Screenshots