CI: add tests & linting for helm charts

[ljubon]

CI: add tests & linting for helm charts

Resolves: https://github.com/G-Research/oss-portfolio-maturity/issues/420

[jgiannuzzi]

The tests seem to be failing 😞
@ljubon could you please fix this?

[ljubon]

The tests seem to be failing 😞 @ljubon could you please fix this?

Hi @jgiannuzzi sorry for not re-running this sooner, it seems some actions required a minor upgrade 🔧
Now it works as expected 🙏

[jgiannuzzi]

could you please show a run of this workflow when a chart has changed?

[ljubon]

could you please show a run of this workflow when a chart has changed?

Hi @jgiannuzzi, I couldn't provide old runs where I tested both no-change and change flow I'm providing you new links to the current code base:

• Example where there is no diff between the default branch and new branch - link
• Example where there is a change on the chart (storm) - link

[jgiannuzzi]

hmm, on the "change" example, it looks like the actual lint and install validation steps are not doing anything because "No chart changes [are] detected".
https://github.com/ljubon/charts/actions/runs/8235146688/job/22518582958#step:7:17
https://github.com/ljubon/charts/actions/runs/8235146688/job/22518582958#step:9:17

[ljubon]

hmm, on the "change" example, it looks like the actual lint and install validation steps are not doing anything because "No chart changes [are] detected". https://github.com/ljubon/charts/actions/runs/8235146688/job/22518582958#step:7:17 https://github.com/ljubon/charts/actions/runs/8235146688/job/22518582958#step:9:17

The change I made was simple in template file without bumping chart version (Chart.yaml) - I'll provide in next example full chart bump example

[ljubon]

Hi @jgiannuzzi, below are the tested workflows and actual code changes that need to happen to fix reported linting errors shown in the workflow (e.g for librenms)

I would like to propose that this PR scope should focus only on introducing linting as a mechanism to prevent big changes in our charts.
In the next PR, I can include fixed errors and use this workflow to validate the change.

Below you can find the example runs as requested for the lint-test.yaml workflow

Testing results

No change to the chart (librenms & storm)

• Workflow

The chart librenms changed, and the version was bumped (action failed due to issues with installing the chart)

• Workflow
• Commit of the change

Reported errors fixed, linting success - librenms

• Workflow (Linting success)
• Commit of the change

Reported errors fixed, linting success - storm

• Commit of the change with included fixed linting problems
• Workflow

Detected issues during installation charts librenms and storm

Storm

With the default set of values, installation failed of storm chart due to:
Failed to pull image "storm:2.4.0": rpc error: code = NotFound desc = failed to pull and unpack image "docker.io/library/storm:2.4.0": no match for platform in manifest: not found

When moved to 2.5.0 in values.yaml - it got installed with success

LibreNMS

Helm chart does not have a manifest which creates a ssd storageClassName which is required for mysql and redis installation

[jgiannuzzi]

I agree with your approach. Looking forward to the chart fixes!