Code to let us sort certain doc categories to top #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…top of their doc section
eventually I want to use this functionality for a new category, but don't want to forget the data structure before then JSON doesn't have comments or I'd leave a valid entry commented out
There was a problem hiding this comment.
I was worried that this would ultimately be difficult to maintain as we would now have two different schemes for managing nav order. Since the data structure is already defined and filled out here, we could just mirror it with a definition of the order using an object of the same shape.
This would allow you to specifiy both the entries and the categories where you want to have a definitive ordering in one place, while the fallback behavior to alphabetical would still be there.
Feel free not to use this approach, just a suggestion (I left your code commented out so you can swap it back if you want :) )
lyleschemmerling
approved these changes
Nov 22, 2024
mooreds
added a commit
that referenced
this pull request
Nov 22, 2024
mooreds
added a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.