Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTA for free trials #3392

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CTA for free trials #3392

wants to merge 3 commits into from

Conversation

lyleschemmerling
Copy link
Contributor

image

Copilot
Copilot AI reviewed Nov 19, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (4)
  • astro/src/components/cta/CTA.astro: Language not supported
  • astro/src/components/cta/FreeTrialCTA.astro: Language not supported
  • astro/src/layouts/Article.astro: Language not supported
  • astro/src/layouts/Default.astro: Language not supported
dcharles8
dcharles8 requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@dcharles8 dcharles8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment regarding the URL. Besides that, click testing all looked good to me.

astro/src/components/cta/FreeTrialCTA.astro Outdated Show resolved Hide resolved
bhalsey
bhalsey requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@bhalsey bhalsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CTA text isn't readable in light mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@bhalsey bhalsey bhalsey requested changes

@dcharles8 dcharles8 dcharles8 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyleschemmerling @bhalsey @dcharles8