Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Linting Config #3373

Merged
merged 18 commits into from
Nov 22, 2024
Merged

Initial Linting Config #3373

merged 18 commits into from
Nov 22, 2024

Conversation

lyleschemmerling
Copy link
Contributor

If I did this right this will check the following:

  • Astro files
  • Javascript files
  • Typescript Files
  • Markdown files
  • MDX files

With a handful of default rules and a special "no html in the markdown" rule.

✖ 5909 problems (5909 errors, 0 warnings)
  402 errors and 0 warnings potentially fixable with the `--fix` option.

Would like some feedback on the rules before anyone starts trying to fix it.

to try it out:

cd astro
npm run lint

@lyleschemmerling lyleschemmerling requested review from a team as code owners November 7, 2024 04:16
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool. I'd suggest fixing as many of the errors as you can (or exempting them) before merging.

@lyleschemmerling
Copy link
Contributor Author

🤠

@lyleschemmerling lyleschemmerling merged commit c28d129 into main Nov 22, 2024
3 checks passed
@lyleschemmerling lyleschemmerling deleted the lyle/automation-poc branch November 22, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants