Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout and session management doc #3148

Merged
merged 43 commits into from
Aug 16, 2024
Merged

Logout and session management doc #3148

merged 43 commits into from
Aug 16, 2024

Conversation

mooreds
Copy link
Contributor

@mooreds mooreds commented Jul 12, 2024

Open questions:

  • Do we want to document the [@helpers.hidden name="metaData.device.description" value="yourdatahere" /] hack that puts values on the SSO refresh token?
  • Is this more than one doc?
  • Should we push the terms 'application managed sessions' and 'centralized sessions' into any other places in the doc?

@mooreds mooreds marked this pull request as ready for review July 12, 2024 23:11
@mooreds mooreds requested a review from a team as a code owner July 30, 2024 00:43
@mooreds mooreds added the content Alert marketing to this change label Aug 7, 2024
Copy link
Contributor

@alex-fusionauth alex-fusionauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this one, wowsers that was a LOT!

@@ -205,6 +205,8 @@ This API has been available since 1.8.0

## Refresh a JWT

This can be used to extend a centrally managed session, when the refresh token is being used to model a session. [Learn more about using refresh tokens to model sessions](/docs/lifecycle/authenticate-users/logout-session-management).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something in this statement seems off to me, does this still make sense to you?

Suggested change
This can be used to extend a centrally managed session, when the refresh token is being used to model a session. [Learn more about using refresh tokens to model sessions](/docs/lifecycle/authenticate-users/logout-session-management).
This can extend a centrally managed session when a refresh token is used to represent the session. [Learn more about using refresh tokens to model sessions](/docs/lifecycle/authenticate-users/logout-session-management).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't accept your suggestion, but did tweak the language. Let me know if it works.

astro/src/content/docs/apis/jwt.mdx Outdated Show resolved Hide resolved
astro/src/content/docs/apis/jwt.mdx Show resolved Hide resolved
@mooreds
Copy link
Contributor Author

mooreds commented Aug 15, 2024

Heya @alex-fusionauth , made some changes you suggested. Also would love your thoughts on the questions in the PR description.

@alex-fusionauth
Copy link
Contributor

alex-fusionauth commented Aug 15, 2024

Open questions:

  • Do we want to document the [@helpers.hidden name="metaData.device.description" value="yourdatahere" /] hack that puts values on the SSO refresh token?
  • Is this more than one doc?
  • Should we push the terms 'application managed sessions' and 'centralized sessions' into any other places in the doc?

@mooreds

  • I don't love this, but think it is okay if we are not going to put a full fix in the future. Is that a fix coming from engineering?
  • I think the way you have it is solid.
  • I really think it is good, unless you are trying for an SEO play.

@mooreds
Copy link
Contributor Author

mooreds commented Aug 15, 2024

Thanks @alex-fusionauth . re first issue, I chatted with the eng team and I'm not going to document it.

@alex-fusionauth
Copy link
Contributor

@mooreds if you want to pull in main we should be good.

@mooreds
Copy link
Contributor Author

mooreds commented Aug 16, 2024

On my list for today. Thanks!

Copy link
Contributor

@alex-fusionauth alex-fusionauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mooreds mooreds merged commit 61c5ec7 into main Aug 16, 2024
4 checks passed
@mooreds mooreds deleted the mooreds/add-logout-doc branch August 16, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Alert marketing to this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants