Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose update #2789

Merged
merged 21 commits into from
Jan 31, 2024

Conversation

Aaron-Ritter
Copy link
Collaborator

@Aaron-Ritter Aaron-Ritter commented Dec 28, 2023

This is the update for fusionauth-site docker, using the latest PostgreSQL release, switching to OpenSearch and adding a weekly dependabot check which addresses the two issues reported:

FusionAuth/fusionauth-issues#2520
FusionAuth/fusionauth-issues#2521

This PR requires https://github.com/sonderformat-llc/fusionauth-example-docker-compose to be copied to FusionAuth and #2758 to be merged as its referencing the update of email templates.

This PR requires FusionAuth/fusionauth-containers#96 to be merged as it's referencing pending updates.


@escii
Copy link
Collaborator

escii commented Dec 29, 2023

The Page "Switching Search Engines" (/docs/lifecycle/manage-users/search/switch-search-engines/) requires an update to emphasize "opensearch" over "elasticsearch".
Also, renaming the configuration setting "elasticsearch" within the fusionauth core to "searchengine" will help avoid favoring any specific product name. This change ensures a more neutral and inclusive approach to the search engine configuration, maybe you need to keep "elasticsearch" as an alias to maintain backward compatibility.

Copy link
Collaborator

@escii escii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No apparent issues spotted. Cool examples.

@Aaron-Ritter
Copy link
Collaborator Author

The Page "Switching Search Engines" (/docs/lifecycle/manage-users/search/switch-search-engines/) requires an update to emphasize "opensearch" over "elasticsearch". Also, renaming the configuration setting "elasticsearch" within the fusionauth core to "searchengine" will help avoid favoring any specific product name. This change ensures a more neutral and inclusive approach to the search engine configuration, maybe you need to keep "elasticsearch" as an alias to maintain backward compatibility.

@mooreds I agree with Mitch that it is confusing but it goes way beyond the scope of the change, I would suggest to create a issue to address this separately.

Beside that the PR is ready.

Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to example apps; seems similar to example kickstarts repo: https://github.com/FusionAuth/fusionauth-site/blob/master/astro/src/content/json/exampleapps.json#L135

I moved over the repo. Please update everything to use https://github.com/fusionauth/fusionauth-example-docker-compose

I don't see where it depends on the fusionauth-containers repo. What am I missing?

@Aaron-Ritter
Copy link
Collaborator Author

I don't see where it depends on the fusionauth-containers repo. What am I missing?

The PR FusionAuth/fusionauth-containers#96 changes the templates to use OpenSearch and are added in the first section of the documentation. Only once the PR is merged the description including OpenSearch in relation to the code makes sense again.

The FusionAuth Docker Compose yaml files may be found on [FusionAuth containers repository](https://github.com/FusionAuth/fusionauth-containers) and more examples in the [FusionAuth docker compose example repository](https://github.com/sonderformat-llc/fusionauth-example-docker-compose) described in more detail below.

<RemoteCode title="docker-compose.yml" url="https://raw.githubusercontent.com/FusionAuth/fusionauth-containers/master/docker/fusionauth/docker-compose.yml" lang="yaml" />

mooreds added a commit that referenced this pull request Jan 3, 2024
Merged. I know why the example app count is off, it's because of this PR: #2789
@Aaron-Ritter
Copy link
Collaborator Author

@mooreds i went through and implemented your review feedback and discovered that there are again docker-compose commands instead of docker compose #2310 which i changed once more too for the ones left over.

alex-fusionauth pushed a commit that referenced this pull request Jan 10, 2024
Merged. I know why the example app count is off, it's because of this PR: #2789
alex-fusionauth added a commit that referenced this pull request Jan 10, 2024
* oauth mobile

* add placeholder image

* Shrink images

* Apply suggestions from code review

Co-authored-by: Mark Robustelli <[email protected]>

* updates from review

* update category

* update to check json files in new location (#2781)

* Update example apps (#2780)

* adding in all the quickstarts

* reviewed all example apps

updated with quickstarts

removed old examples that mapped directly to quickstarts or that were otherwise archived

* Float this page to the top of the nav

* updated fusionauth-containers description

* tweaking categories

* removed navcategory, fixed description

* pull in repos code and place it in examples

* mark example apps under extend -> example apps as canonical

* add in script to count repos

* run from top of repo

* adding new example apps

* adding more example apps

* add in check for count of example apps (#2782)

* add in check for count of example apps

depends on #2780 being merged

* change name

* make GH token available so the gh cli will work

* flex sizing (#2784)

* this didn't work

* better sizing

* hide the cta in articles (#2785)

* finish example apps audit (#2786)

* added in extra repo adjustments

* Added missing examples

* correcting example repos

* added ability to do diffs to help ease finding issues

* finished audit, synced up with what was up in gh

* SEO updates to existing articles (#2777)

* tweaking test

* tweaking calling of script

* fixing busted yaml

* make diagram more explicit around authentication steps (#2787)

* make diagram more explicit around authentication steps

* added in flavor

* more clarifications

* tweaking diagram

* dyanmic year (#2794)

* SEO updates to What is OIDC article (#2788)

* SEO updates to What is OIDC article

* reworked How Does OpenID Connect Fit with OAuth2? section

* update header to make more sense

* correct casing of words in header

---------

Co-authored-by: bradmccarty <[email protected]>
Co-authored-by: Dan Moore <[email protected]>

* fixed markdown error (#2795)

* fixed typo about logout endpoint (#2798)

Merged. I know why the example app count is off, it's because of this PR: #2789

* Category Hero grid updated. (#2797)

Co-authored-by: Sean Bobby <[email protected]>

* added note about limits for postgresql 15 (#2799)

* added note about limits for postgresql 15

* added correct version number

* Sean/docs api updates (#2800)

* Category Hero grid updated.

* Dark mode link hover color update + sidebar nav margin increased.

---------

Co-authored-by: Sean Bobby <[email protected]>

* fix typo (#2801)

* feat(email-templates): refactor and add email templates from 1.48.3 (#2758)

* feat(email-templates): refactor and add email templates from FusionAuth 1.48.3

* refactor(email-templates): change mdx import files to lowercase and dashes

* fix(email-templates): adding .ftl to files in RemoteCode

* fix(email-templates): adding leading underscore to files in RemoteCode

* fix(email-templates): leading underscore not required for source files

* fix(email-templates): rename ftl source files to lowercase-dash format

* refactor(email-templates): import templates for all scenarios

* refactor(email-templates): import scenarios in to other sections of the documentation

* refactor(email-templates): standardize import naming

* feat(email-templates): add download list to be used with wget

* refactor(email-templates): fix txt imports

* refactor(email-templates): apply review feedback

* Mooreds/fix breached password detection email error (#2802)

* make sure to import the text version

* changed wording to be more accurate

* Update robots.txt - Startup Contact Landing Page (#2803)

Landing page disallow for indexing.

* 📝 Improving instructions in the Laravel API quickstart to say that it allows token via cookies and the Authorization header (#2790)

* fix overview page width and missing application request body fields (#2804)

* fix overview page width when no descriptions are avaialable for docs. Add missing application request body fields

* no flexfill

* publish the content check before I publish the fix

* make the content check work

* add in missing names

* oops

* change base field name to remove double-dot on applications response (#2805)

* rolling back dark icon since it doesn't exist (#2806)

* Minor Articles UI Layout Update + New 2024 Icons (Light/Dark Mode) (#2808)

* UI Layout Adjustments + New Icons

* UI Layout Adjustments + New Icons

---------

Co-authored-by: Sean Bobby <[email protected]>

* fix typo (#2809)

* remove comments to pass md ref test

* Shrink images

---------

Co-authored-by: Alex Patterson <[email protected]>
Co-authored-by: alex-fusionauth <[email protected]>
Co-authored-by: Mark Robustelli <[email protected]>
Co-authored-by: Dan Moore <[email protected]>
Co-authored-by: Lyle Schemmerling <[email protected]>
Co-authored-by: Brad McCarty <[email protected]>
Co-authored-by: bradmccarty <[email protected]>
Co-authored-by: Sean Bobby <[email protected]>
Co-authored-by: Sean Bobby <[email protected]>
Co-authored-by: Aaron Ritter <[email protected]>
Co-authored-by: Vinícius Campitelli <[email protected]>
Co-authored-by: Spencer Witt <[email protected]>
@vcampitelli vcampitelli self-requested a review January 30, 2024 22:37
Copy link
Contributor

@vcampitelli vcampitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened sonderformat-llc#1 with a few changes

…ose" instead of "docker compose" and adding `-f` to `docker compose logs` (#1)
@Aaron-Ritter
Copy link
Collaborator Author

merged review changes by @vcampitelli

@vcampitelli vcampitelli requested review from mooreds and removed request for mooreds January 31, 2024 20:19
@mooreds
Copy link
Contributor

mooreds commented Jan 31, 2024

@vcampitelli why did you ask for my review? Is it because you can't self review or something? Is this ready to ship?

@vcampitelli vcampitelli removed the request for review from mooreds January 31, 2024 22:33
@vcampitelli vcampitelli merged commit 21354fc into FusionAuth:master Jan 31, 2024
2 of 3 checks passed
@Aaron-Ritter Aaron-Ritter deleted the docker-compose-update branch February 28, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants