Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating "Testing Lambdas" to MDX #2705

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Conversation

vcampitelli
Copy link
Contributor

@vcampitelli vcampitelli commented Dec 4, 2023

I found it easier to duplicate the branch from #2340 and fix things there as merging or rebasing were kind of complicated.

I've compared both articles a few times before opening this PR.


@vcampitelli vcampitelli self-assigned this Dec 4, 2023
@vcampitelli vcampitelli mentioned this pull request Dec 4, 2023
Copy link
Contributor

@mark-robustelli mark-robustelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get stuck with error message. Think I found out why. Was logged in to admin app and tried to log in as richard too.

Copy link
Contributor

@mark-robustelli mark-robustelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else worked well. It is just the login test that I am having issues with now.
test login returns JWT with "Goodbye World"
not ok 1 TypeError: login is not a function
---
operator: error
stack: |-
TypeError: login is not a function

Copy link
Contributor

@mark-robustelli mark-robustelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a bit better. Still seeing some of the deprecation messages and got one error I had to fix, but I was able to get all the way through it with 6 tests passing.

@vcampitelli
Copy link
Contributor Author

@mark-robustelli I've pushed some changes and this is now ready for re-review

Copy link
Contributor

@mark-robustelli mark-robustelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, only 2 issues. 1) Still getting the deprecation warnings but I think you said we have to update the library to get rid of them so I think that is OK. 2) In the commands to install the testing framework I get errors from the copy and paste because of the comments. Please find another way to comment.

Copy link
Contributor

@mark-robustelli mark-robustelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vcampitelli vcampitelli merged commit baba03e into master Jan 12, 2024
2 checks passed
@vcampitelli vcampitelli deleted the migration/testing-lambdas branch January 12, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants