Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equilibria analysis #3298

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented May 24, 2024

Linked Issues

Part of #675

Description

This PR aims to add the location to build out some equilibria analysis tools. For this starting point it will probably just be plotting and visualisations but this can be expanded in future.

Interface Changes

None

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added enhancement New feature or request equilibria Tasks relating to the equilibria module labels May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (65b42ff) to head (dc04636).

Files Patch % Lines
bluemira/equilibria/analysis.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3298      +/-   ##
===========================================
- Coverage    74.34%   74.28%   -0.06%     
===========================================
  Files          242      243       +1     
  Lines        26902    26915      +13     
===========================================
- Hits         19999    19995       -4     
- Misses        6903     6920      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 24, 2024

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (5)

On runtest

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead

On collect

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.

@je-cook je-cook force-pushed the je-cook/equilibria_analysis branch from 2095bdf to dc04636 Compare June 5, 2024 13:57
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@je-cook je-cook changed the base branch from develop to feature/eq_analysis_tools June 6, 2024 15:18
@je-cook je-cook marked this pull request as ready for review June 6, 2024 15:18
@je-cook je-cook requested a review from a team as a code owner June 6, 2024 15:18
@je-cook je-cook merged commit c1dd295 into feature/eq_analysis_tools Jun 6, 2024
6 of 7 checks passed
@je-cook je-cook deleted the je-cook/equilibria_analysis branch June 6, 2024 15:19
je-cook added a commit that referenced this pull request Jun 24, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Jun 24, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Jun 28, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Jul 5, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Jul 9, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Jul 30, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Aug 9, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Aug 16, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
@je-cook je-cook mentioned this pull request Aug 23, 2024
3 tasks
je-cook added a commit that referenced this pull request Aug 29, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Sep 13, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
geograham pushed a commit that referenced this pull request Oct 3, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Oct 10, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Oct 21, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Oct 22, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
geograham pushed a commit to geograham/bluemira that referenced this pull request Nov 12, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Nov 13, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
je-cook added a commit that referenced this pull request Nov 18, 2024
* 🎨 Small cleanup

* 🚧 Initial structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request equilibria Tasks relating to the equilibria module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant