Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tls configuration parameter allow_missing_crl #5432

Open
wants to merge 2 commits into
base: v3.2.x
Choose a base branch
from
Open

Add tls configuration parameter allow_missing_crl #5432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bae69ee
Add tls configuration parameter allow_missing_crl, which will allow a…
aren Apr 26, 2024
cb49534
Add a reference to allow_missing_crl in the eap config file
aren Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions raddb/mods-available/eap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,10 @@ eap {
#
# allow_expired_crl = no

# Accept a missing Certificate Revocation List
#
# allow_missing_crl = no

# If check_cert_issuer is set, the value will
# be checked against the DN of the issuer in
# the client certificate. If the values do not
Expand Down
1 change: 1 addition & 0 deletions src/include/tls-h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ struct fr_tls_server_conf_t {
bool check_crl;
bool check_all_crl;
bool allow_expired_crl;
bool allow_missing_crl;
uint32_t ca_path_reload_interval;
uint32_t ca_path_last_reload;
X509_STORE *old_x509_store;
Expand Down
11 changes: 11 additions & 0 deletions src/main/tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,6 +1681,7 @@ static CONF_PARSER tls_server_config[] = {
#endif
{ "ca_path_reload_interval", FR_CONF_OFFSET(PW_TYPE_INTEGER, fr_tls_server_conf_t, ca_path_reload_interval), "0" },
{ "allow_expired_crl", FR_CONF_OFFSET(PW_TYPE_BOOLEAN, fr_tls_server_conf_t, allow_expired_crl), NULL },
{ "allow_missing_crl", FR_CONF_OFFSET(PW_TYPE_BOOLEAN, fr_tls_server_conf_t, allow_missing_crl), NULL },
{ "check_cert_cn", FR_CONF_OFFSET(PW_TYPE_STRING, fr_tls_server_conf_t, check_cert_cn), NULL },
{ "cipher_list", FR_CONF_OFFSET(PW_TYPE_STRING, fr_tls_server_conf_t, cipher_list), NULL },
{ "cipher_server_preference", FR_CONF_OFFSET(PW_TYPE_BOOLEAN, fr_tls_server_conf_t, cipher_server_preference), NULL },
Expand Down Expand Up @@ -3206,6 +3207,16 @@ int cbtls_verify(int ok, X509_STORE_CTX *ctx)
X509_STORE_CTX_set_error( ctx, 0 );
}

/*
* If the CRL is missing, that might still be OK
*/
if (!my_ok &&
(conf->allow_missing_crl) &&
(err == X509_V_ERR_UNABLE_TO_GET_CRL)) {
my_ok = 1;
X509_STORE_CTX_set_error( ctx, 0 );
}

if (!my_ok) {
char const *p = X509_verify_cert_error_string(err);
RERROR("(TLS) OpenSSL says error %d : %s", err, p);
Expand Down
Loading