Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.0] Document the new ClientOptions and ServerOptions classes. #66

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

ChadSikorra
Copy link
Contributor

@ChadSikorra ChadSikorra commented Jun 6, 2023

This documents the new ClientOptions and ServerOptions classes that replace the old associative array options that were passed into the client / server. It also replaces usage in the readme. Now that the options objects are in place, I can remove some redundant methods no the LdapServer class as well.

#50

@ChadSikorra ChadSikorra changed the base branch from master to 1.0 June 6, 2023 21:49
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #66 (ea14dcf) into 1.0 (63ff675) will increase coverage by 0.09%.
The diff coverage is 57.14%.

❗ Current head ea14dcf differs from pull request most recent head 69ee130. Consider uploading reports for the commit 69ee130 to get more accurate results

@@             Coverage Diff              @@
##                1.0      #66      +/-   ##
============================================
+ Coverage     86.80%   86.89%   +0.09%     
+ Complexity     1875     1873       -2     
============================================
  Files           131      131              
  Lines          5471     5465       -6     
============================================
  Hits           4749     4749              
+ Misses          722      716       -6     
Impacted Files Coverage Δ
src/FreeDSx/Ldap/ClientOptions.php 81.81% <ø> (+2.40%) ⬆️
...col/ServerProtocolHandler/ServerRootDseHandler.php 89.09% <50.00%> (ø)
src/FreeDSx/Ldap/ServerOptions.php 71.79% <60.00%> (+1.79%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChadSikorra ChadSikorra merged commit 52d4b1a into FreeDSx:1.0 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant