[1.0.0] Use Options objects instead of arrays. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that should be private. Adjust formatting.
ChadSikorra
force-pushed
the
v1-options_objects
branch
6 times, most recently
from
552a333
to
21c42a0
Compare
… associative arrays. This provides more clarity around what the options are and actual type enforcement around values.
ChadSikorra
force-pushed
the
v1-options_objects
branch
from
21c42a0
to
e5f4f65
Compare
ChadSikorra
force-pushed
the
v1-options_objects
branch
from
e5f4f65
to
847fdd3
Compare
Codecov Report
@@ Coverage Diff @@
## 1.0 #64 +/- ##
==========================================
Coverage 86.96% 86.96%
- Complexity 1811 1867 +56
==========================================
Files 129 131 +2
Lines 5278 5447 +169
==========================================
+ Hits 4590 4737 +147
- Misses 688 710 +22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large breaking change, but it is necessary. The array options have been a pain for quite some time. This provides type safety and less confusion over making sure every option is named properly in the array. It also provides a way to reject certain bad option values.
For most users of the library, switching over to this should be straight forward, and the
1.0.0release will be the one time to finally make this change.#50