chore: Remove psutil dependency #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpelsepp
force-pushed
the
psutil
branch
8 times, most recently
from
d1e67b0
to
085634b
Compare
rumpelsepp
requested review from
ferdinandjarisch and
peckto
as code owners
This was referenced Sep 24, 2024
The psutil dependency is used at exactly one location in the codebase. The psutil library claims to be portable, however the broadcast feature is [not supported](https://github.com/giampaolo/psutil/blob/8d943015ffce86de31d9494ffa3a1eae7dd91719/psutil/arch/windows/net.c#L210) on Windows. Since we support Linux as Tier-1 and Windows as Tier-2, let's remove the dependency and use the always available system tooling for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The psutil dependency is used at exactly one location in the codebase.
The psutil library claims to be portable, however the broadcast feature
is not supported on Windows.
Since we support Linux as Tier-1 and Windows as Tier-2, let's remove the
dependency and use the always available system tooling for this.
As for the why remove dependencies that are not really used in gallia: Recently we had a dependency hell situation on a embedded platform; a C compiler toolchain with several special library version was required to build those dependencies via pip (this one uses C-extensions). In order to avoid this situation in the future dependencies without value are removed (see #582, #590).