-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improving documentation #525
base: master
Are you sure you want to change the base?
Conversation
fixed arg help after PR Fraunhofer-AISEC#457
Thank you very much for your effort and your pull request! Very much appreciated! There are a few remarks:
I find your explanations how particular scanners work useful. However, the syncronization problem code <-> documentation still applies. Looking forward, I propose the following:
Thank you for your understanding. I took some time and thought about how to write this answer. I hope it generates only a decent amount of additional work for you! |
I have removed duplicate information from the docstrings, made I would also like to ask for confirmation, Gallia ISOTP Discover does not support 29bit CAN IDs now at all? Wanted to note that in the ISOTP chapter of |
PR Focused on improving documentation to ease the learning curve for newcomers, since a lot of documentation was lacking.
Edited rendered documentation available at ReadTheDocs.