-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scan-reset): added option to power-cycle on timeout #325
base: master
Are you sure you want to change the base?
Conversation
8f51f73
to
8a56554
Compare
We could take the opportunity and refactor this thing. The |
Reworked in #413. |
As far as I can see, #413 does not fully include all the cases which are handled here, so I don't think that this should be closed already. |
Which one is still missing? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ECUReset can trigger shutdowns of ECUs which currently leads to TimeoutError, which in turns leads to termination of the scanner.
This commit, introduces the cli option
--power-cycle-on-timeout
. In case this option is set, the ECU power-cycles the ECU after such a timeout and tries to reconnect to the ECU afterwards.Tested with isotp and connection-oriented protocols.
Co-authored by @VeroSec and @emedav