Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change jep dependency from api to implementation #1855

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

maximiliankaul
Copy link
Contributor

No need to expose jep's API to CPG users.

@maximiliankaul maximiliankaul marked this pull request as ready for review November 19, 2024 18:15
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (3a430fc) to head (dc6c7d4).
Report is 1 commits behind head on main.

Additional details and impacted files

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@oxisto
Copy link
Member

oxisto commented Nov 19, 2024

Are you sure about that? If one uses the python frontend, I am pretty sure they need JEP as a dependency and it won't be registered to them as a dependency unless its an api dependency.

@maximiliankaul
Copy link
Contributor Author

Are you sure about that? If one uses the python frontend, I am pretty sure they need JEP as a dependency and it won't be registered to them as a dependency unless its an api dependency.

No, I'm not at all sure about this entire build system.

  • I don't see why the jep API being exposed to the end-user would be of any benefit.
  • Test (local and on GitHub) still work just fine.
  • Using the CPG stand-alone (say cpg-console) works fine.

If there are any other tests you'd like me to do, then I'm happy for any pointers :)

@oxisto
Copy link
Member

oxisto commented Nov 19, 2024

Are you sure about that? If one uses the python frontend, I am pretty sure they need JEP as a dependency and it won't be registered to them as a dependency unless its an api dependency.

No, I'm not at all sure about this entire build system.

  • I don't see why the jep API being exposed to the end-user would be of any benefit.
  • Test (local and on GitHub) still work just fine.
  • Using the CPG stand-alone (say cpg-console) works fine.

If there are any other tests you'd like me to do, then I'm happy for any pointers :)

Running from an external project still works. LGTM then

@oxisto oxisto merged commit 66aa2da into main Nov 19, 2024
4 checks passed
@oxisto oxisto deleted the mk/pythonBuild branch November 19, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants