Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more extensions to follow edges until the end #1853

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

KuechA
Copy link
Contributor

@KuechA KuechA commented Nov 19, 2024

More homogeneous interfaces of the followX... extensions, and more functions which follow the edges until the end (without condition)

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 20.58824% with 54 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (90a1534) to head (86b9431).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 18.18% 54 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...main/kotlin/de/fraunhofer/aisec/cpg/query/Query.kt 61.25% <100.00%> (ø)
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 53.13% <18.18%> (-9.42%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to be. However, it'd be nice to have some tests... But we already talked about this and that it'd be a lot of work to come up with all the fluent dsl code -> I get why there aren't any tests right now...

@KuechA KuechA enabled auto-merge (squash) November 20, 2024 08:57
@oxisto oxisto disabled auto-merge November 21, 2024 13:48
@oxisto oxisto enabled auto-merge (squash) November 21, 2024 13:49
@oxisto oxisto merged commit 37987af into main Nov 21, 2024
2 checks passed
@oxisto oxisto deleted the ak/more-follow-extensions branch November 21, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants