Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified and more basic fixpoint iteration #1810

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

KuechA
Copy link
Contributor

@KuechA KuechA commented Nov 5, 2024

The current fix-point iteration system is a bit tricky to understand and hard to debug. I'd try to remove some of the bloat and simplify it. In particular, it should keep less states (i.e., save memory, remove a bunch of indirections) and copy objects instead of manipulating them (which should make it easier to understand things).

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 73.63636% with 29 lines in your changes missing coverage. Please review.

Project coverage is 75.08%. Comparing base (afad877) to head (5bd0ad2).

Files with missing lines Patch % Lines
...nhofer/aisec/cpg/helpers/functional/EOGWorklist.kt 0.00% 20 Missing ⚠️
...ofer/aisec/cpg/helpers/functional/BasicLattices.kt 90.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../fraunhofer/aisec/cpg/passes/UnreachableEOGPass.kt 87.93% <ø> (ø)
...ofer/aisec/cpg/helpers/functional/BasicLattices.kt 90.00% <90.00%> (ø)
...nhofer/aisec/cpg/helpers/functional/EOGWorklist.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant