Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.7 support. Added 3.9 dependencies and removed 3.12 from CI. #31

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

gsolard
Copy link
Collaborator

@gsolard gsolard commented Oct 13, 2023

✒️ Context

The tests are not passing due to silly mistakes and the spacy model being in setup.py

  • What kind of change does this PR introduce ?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe:

🧱 Description of Changes

Properly deleted python 3.12 from CI
Added dependencies for 3.9 in setup.py
Removed 3.7 support
Removed the model from setup.py

🩺 Testing

  • Add bullet points summarizing your changes here

    • This change does not need new tests
    • Added/Updated unit tests

By submitting this pull request you agree that all contributions to this project are made under the GNU AFFERO GENERAL PUBLIC LICENSE.

@gsolard gsolard self-assigned this Oct 13, 2023
@gsolard gsolard changed the title Added 3.9 dependencies and removed 3.12 from CI Added 3.9 dependencies and removed 3.12 from CI. Oct 13, 2023
@gsolard gsolard changed the title Added 3.9 dependencies and removed 3.12 from CI. Remove 3.7 support. Added 3.9 dependencies and removed 3.12 from CI. Oct 13, 2023
@gsolard gsolard merged commit a54e654 into main Oct 13, 2023
25 checks passed
@gsolard gsolard deleted the fix/fix_39 branch October 13, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant