Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url redirect doc page #1079

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Url redirect doc page #1079

merged 3 commits into from
Oct 11, 2024

Conversation

nlkluth
Copy link
Member

@nlkluth nlkluth commented Oct 11, 2024

Description

Fixes a broken link via permanent redirect

Fixes # #1060

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Visit https://nuka-carousel-website-git-url-redirect-doc-page-formidable-labs.vercel.app/open-source/nuka-carousel/api and see the redirect to https://nuka-carousel-website-git-url-redirect-doc-page-formidable-labs.vercel.app/open-source/nuka-carousel/

Checklist

  • My code follows the style guidelines of this project (I have run pnpm run lint)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run pnpm run test:ci-with-server/pnpm run test)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have recorded any user-facing fixes or changes with pnpm changeset.
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: b6924d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuka-carousel-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 4:46pm

@nlkluth nlkluth merged commit 776b32f into main Oct 11, 2024
3 checks passed
@nlkluth nlkluth deleted the url-redirect-doc-page branch October 11, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants