Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make addLogContext accept a record with multiple params #1288

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

LoicPoullain
Copy link
Member

Issue

  • The signature of the method Logger.addLogContext is different from the other logging methods (info, warn, etc) in the way to pass the context (key/value vs record).
  • When we want to add merge a object to the log context, it is tedious to do it because we need to call the method for each key.

Solution and steps

  • Convert the method signature from Logger.addLogContext(key, value) to Logger.addLogContext(context)

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Aug 22, 2024
14 tasks
@LoicPoullain LoicPoullain merged commit c2c4c49 into v5-0-0 Aug 22, 2024
2 checks passed
@LoicPoullain LoicPoullain deleted the log-context branch August 22, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

1 participant